Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 1) #34318

Closed
dcoudert opened this issue Aug 9, 2022 · 9 comments
Closed

pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 1) #34318

dcoudert opened this issue Aug 9, 2022 · 9 comments

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Aug 9, 2022

start cleaning src/sage/graphs/generic_graph.py

Component: graph theory

Author: David Coudert

Branch/Commit: 328cc6a

Reviewer: Sebastian Oehms

Issue created by migration from https://trac.sagemath.org/ticket/34318

@dcoudert dcoudert added this to the sage-9.7 milestone Aug 9, 2022
@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 9, 2022

New commits:

444a55atrac #34318: clean src/sage/graphs/generic_graph.py - part 1

@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 9, 2022

Branch: public/graphs/34318_gen1

@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 9, 2022

Commit: 444a55a

@soehms
Copy link
Member

soehms commented Aug 16, 2022

comment:2

I would take the occasion to fix the pyflakes hint as well, for example

diff --git a/src/sage/graphs/generic_graph.py b/src/sage/graphs/generic_graph.py
index b8a2a920da..7063a348af 100644
--- a/src/sage/graphs/generic_graph.py
+++ b/src/sage/graphs/generic_graph.py
@@ -10871,7 +10871,7 @@ class GenericGraph(GenericGraph_pyx):
         except AttributeError:
             assoc = self._assoc = {}

-        self._assoc[vertex] = object
+        assoc[vertex] = object

If done, this can get a positive review.

@soehms
Copy link
Member

soehms commented Aug 16, 2022

Reviewer: Sebastian Oehms

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 16, 2022

Changed commit from 444a55a to 328cc6a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 16, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

328cc6atrac #34318: fix pyflakes issue

@dcoudert
Copy link
Contributor Author

comment:4

I fixed the issue.

Thank you for the review.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from public/graphs/34318_gen1 to 328cc6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants