Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix E251 in combinat/sf #34321

Closed
fchapoton opened this issue Aug 9, 2022 · 9 comments
Closed

fix E251 in combinat/sf #34321

fchapoton opened this issue Aug 9, 2022 · 9 comments
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

about

E251 unexpected spaces around keyword / parameter equals

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 6fed145

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34321
@fchapoton fchapoton added this to the sage-9.7 milestone Aug 9, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34321

@fchapoton
Copy link
Contributor Author

Commit: 6a26dcb

@fchapoton
Copy link
Contributor Author

New commits:

6a26dcbfix E251 in combinat/sf

@dcoudert
Copy link
Contributor

dcoudert commented Aug 9, 2022

comment:2

In src/sage/combinat/sf/macdonald.py, you let a space before (

+        self.register_coercion( phi)

In src/sage/combinat/sf/witt.py, why not removing the spaces after self (several places)

+            self   .register_coercion(self._p._module_morphism(self._p_to_w_on_basis, codomain=self))

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2022

Changed commit from 6a26dcb to 6fed145

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6fed145details in sf/

@fchapoton
Copy link
Contributor Author

comment:4

merci, c'est fait

@dcoudert
Copy link
Contributor

dcoudert commented Aug 9, 2022

Reviewer: David Coudert

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/chapoton/34321 to 6fed145

@vbraun vbraun closed this as completed in 7171eae Aug 30, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert