EnumeratedSets: Add method 'tuple', avoid making copies

[mkoeppe]

We change the attribute _list to actually store a tuple of the elements and switch methods such as _iterator_from_list to use the new tuple method instead of going through list (which makes a copy every time).

sage: L = list(range(100))
sage: %timeit list(L)
341 ns ± 5.13 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)
sage: %timeit tuple(L)
320 ns ± 9.19 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)
sage: T = tuple(range(100))
sage: %timeit list(T)
354 ns ± 2.88 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)
sage: %timeit tuple(T)
53.5 ns ± 0.764 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

CC: @tscrim @seblabbe @fchapoton @nthiery

Component: combinatorics

Author: Matthias Koeppe

Branch/Commit: d1a6b08

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34400

[mkoeppe]

Branch: u/mkoeppe/enumeratedsets__add_methods_tuple___tuple_from_iterator

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

bf55daf

EnumeratedSets.ParentMethods.tuple: New, replace many uses of list

[mkoeppe]

Commit: bf55daf

[mkoeppe]

comment:5

Existing classes that define specialized list methods can (but don't have to be) changed to define tuple methods instead to avoid a tiny bit of copying overhead

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d573cbf	InfiniteEnumeratedSets.ParentMethods.tuple: New
192a5a2	src/sage/categories/enumerated_sets.py: Add doc
d62fe4c	src/sage/categories/enumerated_sets.py: Fix _tuple_from_iterator

[sagetrac-git]

Changed commit from bf55daf to d62fe4c

[tscrim]

comment:10

Other than adding at least one doctest to the added methods, LGTM. This is a good idea.

[tscrim]

Reviewer: Travis Scrimshaw

[mkoeppe]

comment:13

Ah right, I'll add some tests

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e4e834a

src/sage/categories/enumerated_sets.py: Add doc for _tuple_from_iterator, _tuple_from_list

[sagetrac-git]

Changed commit from d62fe4c to e4e834a

[tscrim]

comment:15

Thanks. Green bot => positive review.

[tscrim]

comment:16

Actually, you missed def tuple(self): in finite_enumerated_sets.py.

[mkoeppe]

comment:17

Indeed. I think my eyeballs need some rest

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fe5bb99

src/sage/categories/finite_enumerated_sets.py: Add missing doctest

[sagetrac-git]

Changed commit from e4e834a to fe5bb99

[tscrim]

comment:19

Thank you.

Trivial detail that you don't have to do, but EXAMPLE:: -> EXAMPLES:: to follow our general practice within Sage.

Green bot => positive review.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d1a6b08

src/sage/categories/finite_enumerated_sets.py: EXAMPLE:: -> EXAMPLES::

[sagetrac-git]

Changed commit from fe5bb99 to d1a6b08

[mkoeppe]

comment:21

Thanks, done.

[mkoeppe]

comment:22

Bots are green

[vbraun]

Changed branch from u/mkoeppe/enumeratedsets__add_methods_tuple___tuple_from_iterator to d1a6b08