Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make new composite elliptic-curve isogenies the default #34410

Closed
yyyyx4 opened this issue Aug 22, 2022 · 9 comments
Closed

make new composite elliptic-curve isogenies the default #34410

yyyyx4 opened this issue Aug 22, 2022 · 9 comments

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Aug 22, 2022

Since #32744, Sage has a specialized class EllipticCurveHom_composite for composite elliptic-curve isogenies which is designed to behave the same as other, non-factored isogenies.

In this patch, we change the default composition for EllipticCurveHom instances from generic formal composite morphisms to the specialized implementation.

Depends on #34409

CC: @JohnCremona

Component: elliptic curves

Author: Lorenz Panny

Branch/Commit: 7326051

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34410

@yyyyx4 yyyyx4 added this to the sage-9.8 milestone Aug 22, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 22, 2022

Commit: 701f1bc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 22, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

fd50425remove experimental warnings for composite elliptic-curve isogenies
701f1bcchange default composition of EllipticCurveHom to EllipticCurveHom_composite

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2022

Changed commit from 701f1bc to b33e5da

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

41ed8a7remove experimental warnings for composite elliptic-curve isogenies
c9726dachange default composition of EllipticCurveHom to EllipticCurveHom_composite
b33e5daremove methods deprecated in #32744

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Changed commit from b33e5da to 7326051

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

7326051Merge tag '9.8.beta1' into public/change_default_composition_for_elliptic_curve_isogenies

@tscrim
Copy link
Collaborator

tscrim commented Oct 1, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 1, 2022

comment:5

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants