Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix various linter errors #34466

Closed
yyyyx4 opened this issue Sep 1, 2022 · 9 comments
Closed

fix various linter errors #34466

yyyyx4 opened this issue Sep 1, 2022 · 9 comments
Labels
p: critical / 2 t: enhancement t: refactoring
Milestone
sage-9.8

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Sep 1, 2022

This should make the linters on GitHub happy.

CC: @fchapoton

Component: refactoring

Author: Lorenz Panny

Branch/Commit: 1b47457

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/34466
@yyyyx4 yyyyx4 added this to the sage-9.7 milestone Sep 1, 2022
@fchapoton
Copy link
Contributor

comment:3

the r in function special is also in another recent ticket..

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2022

Changed commit from 6e5a368 to 1b47457

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1b47457preempt merge conflict

@yyyyx4
Copy link
Member Author

yyyyx4 commented Sep 1, 2022

comment:5

Okay, undone here.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 1, 2022

comment:6

Duplicate of #34465.

@kwankyu kwankyu removed this from the sage-9.7 milestone Sep 1, 2022
@fchapoton
Copy link
Contributor

comment:7

no, this is not a duplicate. Compare the commits

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton fchapoton added this to the sage-9.7 milestone Sep 1, 2022
@kwankyu
Copy link
Collaborator

kwankyu commented Sep 1, 2022

comment:8

I only saw the commit, not the branch. Sorry!

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@vbraun
Copy link
Member

vbraun commented Sep 20, 2022

Changed branch from public/fix_various_linter_complaints to 1b47457

@vbraun vbraun closed this as completed in cba244e Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: critical / 2 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
5 participants
@vbraun @kwankyu @fchapoton @mkoeppe @yyyyx4