Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh the file categories/rings.py #34638

Closed
fchapoton opened this issue Oct 9, 2022 · 11 comments
Closed

refresh the file categories/rings.py #34638

fchapoton opened this issue Oct 9, 2022 · 11 comments
Labels
c: categories p: minor / 4 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

some pep8 details, mainly

CC: @tscrim @kwankyu @kliem @slel

Component: categories

Author: Frédéric Chapoton

Branch/Commit: 0de22b1

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34638
@fchapoton fchapoton added this to the sage-9.8 milestone Oct 9, 2022
@fchapoton
Copy link
Contributor Author

Commit: 790a684

@fchapoton
Copy link
Contributor Author

New commits:

790a684refresh the file categories/rings.py

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34638

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

854064efix doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2022

Changed commit from 790a684 to 854064e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 11, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0de22b1fix the doc (using trac role)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 11, 2022

Changed commit from 854064e to 0de22b1

@fchapoton
Copy link
Contributor Author

comment:4

green bot, so please review

@tscrim
Copy link
Collaborator

tscrim commented Oct 24, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 24, 2022

comment:5

LGTM.

@vbraun
Copy link
Member

vbraun commented Nov 7, 2022

Changed branch from u/chapoton/34638 to 0de22b1

@vbraun vbraun closed this as completed in 6b70584 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: categories p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton