Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some details about INPUT and INPUT in the doc #34699

Closed
fchapoton opened this issue Oct 28, 2022 · 18 comments
Closed

some details about INPUT and INPUT in the doc #34699

fchapoton opened this issue Oct 28, 2022 · 18 comments

Comments

@fchapoton
Copy link
Contributor

namely, add empty line after it when it is missing

also separate if the content is multiline

found using

git grep -A1 "PUT:" src/ | grep -v "PUT:" | grep "py-.*[a-z]"

CC: @tscrim @slel @kwankyu @kliem

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 7fc01de

Reviewer: Travis Scrimshaw, David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34699

@fchapoton fchapoton added this to the sage-9.8 milestone Oct 28, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34699

@fchapoton
Copy link
Contributor Author

Commit: 87b4d8e

@fchapoton
Copy link
Contributor Author

New commits:

87b4d8esome details about OUTPUT and INPUT in the doc

@fchapoton

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2022

Changed commit from 87b4d8e to fdfa523

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

fdfa523a few more details

@tscrim
Copy link
Collaborator

tscrim commented Oct 29, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 29, 2022

comment:4

A while-we-are-at-it thing you can ignore if you want, but the bullet points in categories/examples/ are overindented by the space. Otherwise LGTM.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2022

Changed commit from fdfa523 to 7fdda63

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

7fdda63fix suggested details

@fchapoton
Copy link
Contributor Author

comment:6

thanks, done

@dcoudert
Copy link
Contributor

comment:7

in src/sage/algebras/free_algebra_quotient.py

-    def _coerce_map_from_(self,S):
+    def _coerce_map_from_(self,S ):

In src/sage/categories/examples/finite_coxeter_groups.py: - `n` -- an integer with `n>=2` -> - `n` -- an integer with `n\geq 2` ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2022

Changed commit from 7fdda63 to 7fc01de

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

7fc01demore fixes

@fchapoton
Copy link
Contributor Author

comment:9

merci, voila. J'en ai profité pour nettoyer les deux fichiers.

@dcoudert
Copy link
Contributor

comment:10

LGTM.

@dcoudert
Copy link
Contributor

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, David Coudert

@vbraun
Copy link
Member

vbraun commented Nov 7, 2022

Changed branch from u/chapoton/34699 to 7fc01de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants