Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated use of PyEval_Call* #34702

Closed
fchapoton opened this issue Oct 30, 2022 · 9 comments
Closed

fix deprecated use of PyEval_Call* #34702

fchapoton opened this issue Oct 30, 2022 · 9 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

Deprecated since Python 3.9 - https://docs.python.org/3/whatsnew/3.9.html?highlight=pyeval_callobject#changes-in-the-c-api

using PyObject_Call instead

https://docs.python.org/3/c-api/call.html#c.PyObject_Call

CC: @tscrim @kwankyu @kliem @slel

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 285c58f

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34702
@fchapoton fchapoton added this to the sage-9.8 milestone Oct 30, 2022
@fchapoton
Copy link
Contributor Author

Commit: d9de90a

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34702

@fchapoton
Copy link
Contributor Author

New commits:

d9de90afix deprecated use of PyEval_Call

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2022

Changed commit from d9de90a to 285c58f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

285c58ffix detail

@fchapoton fchapoton changed the title fix deprecated use of PyEvall_Call* fix deprecated use of PyEval_Call* Oct 30, 2022
@fchapoton
Copy link
Contributor Author

comment:4

green lights, so please review

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 30, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Nov 7, 2022

Changed branch from u/chapoton/34702 to 285c58f

@vbraun vbraun closed this as completed in dee9752 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe