Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partial pep8 cleanup for number_field.py #34712

Closed
fchapoton opened this issue Oct 31, 2022 · 13 comments
Closed

partial pep8 cleanup for number_field.py #34712

fchapoton opened this issue Oct 31, 2022 · 13 comments
Labels
c: number fields p: major / 3 t: enhancement
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

also a few little code tweaks

CC: @tscrim @kwankyu @kliem @slel

Component: number fields

Author: Frédéric Chapoton

Branch/Commit: b694ec2

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34712
@fchapoton fchapoton added this to the sage-9.8 milestone Oct 31, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34712

@fchapoton
Copy link
Contributor Author

Commit: 810fc34

@fchapoton
Copy link
Contributor Author

New commits:

810fc34partial pep8 cleanup for number_field.py

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 1, 2022

comment:2

tests fail with RecursionError

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

de39745fix wrong change

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 1, 2022

Changed commit from 810fc34 to de39745

@fchapoton
Copy link
Contributor Author

comment:4

Fixed, was __n and not _n

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 1, 2022

comment:5

I'd think it's better to just remove the commented-out version of _will_be_better_coerce_from_other_cyclotomic_field. It's from 2007 and it's unlikely that someone will just pick it up from this commented out code after > 15 years.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 2, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b694ec2remove old commented code, fix more pep8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 2, 2022

Changed commit from de39745 to b694ec2

@fchapoton
Copy link
Contributor Author

comment:7

green bot, so please review

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 3, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Nov 7, 2022

Changed branch from u/chapoton/34712 to b694ec2

@vbraun vbraun closed this as completed in a2850f8 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: number fields p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe