Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .torsion_basis() method to EllipticCurve_finite_field #34718

Closed
yyyyx4 opened this issue Nov 3, 2022 · 3 comments · Fixed by #34982
Closed

add .torsion_basis() method to EllipticCurve_finite_field #34718

yyyyx4 opened this issue Nov 3, 2022 · 3 comments · Fixed by #34982
Labels
c: elliptic curves p: minor / 4 t: enhancement

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Nov 3, 2022 •
edited by mkoeppe
Loading

Computing a basis of a particular m-torsion subgroup is an important subroutine in several algorithms for isogenies and endomorphism rings of elliptic curves over finite fields.

This patch adds a .torsion_basis() method to EllipticCurve_finite_field. Its current implementation is merely a thin wrapper around .abelian_group() and .torsion_subgroup() — the point of this patch is to introduce the interface first so that more optimizations can be incorporated later.

CC: @defeo

Component: elliptic curves

Author: Lorenz Panny

Issue created by migration from https://trac.sagemath.org/ticket/34718
@yyyyx4 yyyyx4 added this to the sage-9.8 milestone Nov 3, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f882209add .torsion_basis() method to EllipticCurve_finite_field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2022

Changed commit from e7e40f0 to f882209

@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
This was referenced Jan 29, 2023
Closed
Merged
@mkoeppe
Copy link
Member

mkoeppe commented Feb 12, 2023

Removed branch from the issue description because it has been replaced by PR #34982

@vbraun vbraun closed this as completed in da48f14 Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: elliptic curves p: minor / 4 t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add .torsion_basis() method to EllipticCurve_finite_field yyyyx4/sage
2 participants
@mkoeppe @yyyyx4