Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix all W391 in pyx files #34753

Closed
fchapoton opened this issue Nov 16, 2022 · 5 comments
Closed

fix all W391 in pyx files #34753

fchapoton opened this issue Nov 16, 2022 · 5 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

namely, no empty final lines

already done for py files, and will be added to the linter later

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: cd0e58d

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34753
@fchapoton fchapoton added this to the sage-9.8 milestone Nov 16, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34753

@fchapoton
Copy link
Contributor Author

New commits:

cd0e58dfix W391 in pyx files (no empty final lines)

@fchapoton
Copy link
Contributor Author

Commit: cd0e58d

@mkoeppe
Copy link
Member

mkoeppe commented Nov 17, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Dec 3, 2022

Changed branch from u/chapoton/34753 to cd0e58d

@vbraun vbraun closed this as completed in 513a7bc Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @mkoeppe