Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove module-level imports from sage.plot #34754

Closed
mkoeppe opened this issue Nov 17, 2022 · 8 comments
Closed

Remove module-level imports from sage.plot #34754

mkoeppe opened this issue Nov 17, 2022 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 17, 2022

... so that modularized distributions do not have to depend on matplotlib.

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: b50cd0b

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34754
@mkoeppe mkoeppe added this to the sage-9.8 milestone Nov 17, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2022

Branch: u/mkoeppe/remove_module_level_imports_from_sage_plot

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2022

New commits:

b50cd0bRemove module-level imports from sage.plot

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2022

Commit: b50cd0b

@dimpase
Copy link
Member

dimpase commented Nov 17, 2022

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2022

comment:4

This doctest failure is unrelated

sage -t --random-seed=104608529635632774879741932645446645768 sage/interfaces/expect.py  # 2 doctests failed

@dimpase
Copy link
Member

dimpase commented Nov 18, 2022

comment:5

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2022

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 3, 2022

Changed branch from u/mkoeppe/remove_module_level_imports_from_sage_plot to b50cd0b

@vbraun vbraun closed this as completed in 3c42a39 Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe