Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove src/sage/libs/fes.pyx #34761

Closed
mkoeppe opened this issue Nov 19, 2022 · 15 comments
Closed

Remove src/sage/libs/fes.pyx #34761

mkoeppe opened this issue Nov 19, 2022 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 19, 2022

We don't have fes as a package. It was an old-style package.

It exists in Fedora (https://repology.org/project/fes/versions) but upstream is defunct.

CC: @kiwifb @jhpalmieri

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 1ecd042

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/34761

@mkoeppe mkoeppe added this to the sage-9.8 milestone Nov 19, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 19, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 19, 2022

Commit: 444d3f3

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 19, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 19, 2022

New commits:

444d3f3src/sage/libs/fes.pyx: Remove

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e7c8026src/sage/rings/polynomial/multi_polynomial_sequence.py: Remove use of fes
8ed33a0src/doc/en/reference/libs/index.rst: Remove fes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2022

Changed commit from 444d3f3 to 8ed33a0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2022

Changed commit from 8ed33a0 to 1ecd042

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1ecd042src/doc/en/reference/libs/index.rst: Remove fes

@jhpalmieri
Copy link
Member

comment:5

Is https://github.com/cbouilla/libfes-lite any use? Or should we just say, if someone wants to incorporate it, they can start from scratch or revive the deleted file?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 19, 2022

comment:6

I don't know anything about this library other than that it has not been available in Sage for a long time now and nobody seems to have missed it.

@jhpalmieri
Copy link
Member

comment:7

Okay, let's remove it.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 20, 2022

comment:8

Thanks! This will simplify #34346.

@vbraun
Copy link
Member

vbraun commented Dec 3, 2022

Changed branch from u/mkoeppe/remove_src_sage_libs_fes_pyx to 1ecd042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants