Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade matplotlib to 3.6 #34796

Closed
mkoeppe opened this issue Nov 27, 2022 · 22 comments
Closed

Upgrade matplotlib to 3.6 #34796

mkoeppe opened this issue Nov 27, 2022 · 22 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-9.8

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 27, 2022

As matplotlib 3.6 dependency, new standard package contourpy is added.

Depends on #34693

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: dac5ece

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34796
@mkoeppe mkoeppe added this to the sage-9.8 milestone Nov 27, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 27, 2022

Branch: u/mkoeppe/upgrade_matplotlib_to_3_6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 27, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 27, 2022

New commits:

8b0c147Merge branch 'mpl3.6_doctest' into mpl3.6_docbuilding
4645a0dRemoving faulty plot
20206ffMerge #34693
e96e7a6build/pkgs/matplotlib: Update to 3.6.2
18a9e23build/pkgs/matplotlib_inline: Update to 0.1.6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 27, 2022

Commit: 18a9e23

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 27, 2022

comment:3

needs setuptools_scm>=7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 27, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

ed959c1build/pkgs/setuptools_scm: Update to 7.0.5
df9d613build/pkgs/setuptools_scm_git_archive: Update to 1.4
0ecabe5build/pkgs/contourpy: New (matplotlib dependency)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 27, 2022

Changed commit from 18a9e23 to 0ecabe5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 1, 2022

Changed commit from 0ecabe5 to bd54629

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f0a7703Add back doctest
8371dd7Missing part of the fix
dbfb953Merge branch 'develop' into t/34693/MPL3.6_docbuilding
a8741d8Edit the doctest
6458968More edis of the doctest
bd54629Merge #34693

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 2, 2022

Changed branch from u/mkoeppe/upgrade_matplotlib_to_3_6 to u/klee/upgrade_matplotlib_to_3_6

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 2, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 2, 2022

New commits:

58800b0A tiny edit to kick off testing

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 2, 2022

Changed commit from bd54629 to 58800b0

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 2, 2022

comment:9

matplotlib seems (order-)dependent on contourpy.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 2, 2022

comment:10

Yes, looks I forgot to add the dependency.

@kwankyu

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 2, 2022

Changed branch from u/klee/upgrade_matplotlib_to_3_6 to u/mkoeppe/upgrade_matplotlib_to_3_6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 2, 2022

New commits:

dac5ecebuild/pkgs/matplotlib/dependencies: Add contourpy

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 2, 2022

Changed commit from 58800b0 to dac5ece

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 2, 2022

comment:15

Build&Test passed green.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 2, 2022

comment:16

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 11, 2022

Changed branch from u/mkoeppe/upgrade_matplotlib_to_3_6 to dac5ece

@vbraun vbraun closed this as completed in 325b7c1 Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @kwankyu @mkoeppe