Failing doctests in src/sage/modular/modform_hecketriangle #35273

GMS103 · 2023-03-13T17:39:28Z

Is there an existing issue for this?

I have searched the existing issues for a bug report that matches the one I want to file, without success.

Did you read the documentation and troubleshoot guide?

I have read the documentation and troubleshoot guide

Environment

- OS:  macOS (not relevant I think)
- Sage Version:  10.0.beta4

Steps To Reproduce

make ptestlong gives

sage -t --long --warn-long 56.6 --random-seed=452785398975339820822274837493975258 src/sage/modular/modform_hecketriangle/abstract_space.py  # 3 doctests failed
sage -t --long --warn-long 56.6 --random-seed=452785398975339820822274837493975258 src/sage/modular/modform_hecketriangle/readme.py  # 1 doctest failed
sage -t --long --warn-long 56.6 --random-seed=452785398975339820822274837493975258 src/sage/modular/modform_hecketriangle/space.py  # 2 doctests failed

Expected Behavior

All tests passed!

Actual Behavior

sage -t --long --warn-long 56.6 --random-seed=452785398975339820822274837493975258 src/sage/modular/modform_hecketriangle/abstract_space.py
**********************************************************************
File "src/sage/modular/modform_hecketriangle/abstract_space.py", line 1268, in sage.modular.modform_hecketriangle.abstract_space.FormsSpace_abstract.F_basis
Failed example:
    MF.F_basis(1)
Expected:
    q - 13071/(640000*d^2)*q^3 + O(q^4)
Got:
    q + (13071/(-640000*d^2))*q^3 + O(q^4)
**********************************************************************
File "src/sage/modular/modform_hecketriangle/abstract_space.py", line 1444, in sage.modular.modform_hecketriangle.abstract_space.FormsSpace_abstract.quasi_part_gens
Failed example:
    MF.quasi_part_gens(r=0)
Expected:
    [q - 34743/(640000*d^2)*q^3 + O(q^4), q^2 - 69/(200*d)*q^3 + O(q^4)]
Got:
    [q + (34743/(-640000*d^2))*q^3 + O(q^4), q^2 - 69/(200*d)*q^3 + O(q^4)]
**********************************************************************
File "src/sage/modular/modform_hecketriangle/abstract_space.py", line 1446, in sage.modular.modform_hecketriangle.abstract_space.FormsSpace_abstract.quasi_part_gens
Failed example:
    MF.quasi_part_gens(r=1)
Expected:
    [q - 9/(200*d)*q^2 + 37633/(640000*d^2)*q^3 + O(q^4),
     q^2 + 1/(200*d)*q^3 + O(q^4)]
Got:
    [q + (9/(-200*d))*q^2 + (-37633/(-640000*d^2))*q^3 + O(q^4),
     q^2 + 1/(200*d)*q^3 + O(q^4)]
**********************************************************************

sage -t --long --warn-long 56.6 --random-seed=452785398975339820822274837493975258 src/sage/modular/modform_hecketriangle/readme.py
**********************************************************************
File "src/sage/modular/modform_hecketriangle/readme.py", line 999, in sage.modular.modform_hecketriangle.readme
Failed example:
    MF.F_basis(1)
Expected:
    q - 13071/(640000*d^2)*q^3 + O(q^4)
Got:
    q + (13071/(-640000*d^2))*q^3 + O(q^4)
**********************************************************************

sage -t --long --warn-long 56.6 --random-seed=452785398975339820822274837493975258 src/sage/modular/modform_hecketriangle/space.py
**********************************************************************
File "src/sage/modular/modform_hecketriangle/space.py", line 399, in sage.modular.modform_hecketriangle.space.QuasiCuspForms.gens
Failed example:
    MF.gens()
Expected:
    [q - 17535/(262144*d^2)*q^3 + O(q^4),
     q^2 - 47/(128*d)*q^3 + O(q^4),
     q - 9/(128*d)*q^2 + 15633/(262144*d^2)*q^3 + O(q^4),
     q^2 - 7/(128*d)*q^3 + O(q^4),
     q - 23/(64*d)*q^2 - 3103/(262144*d^2)*q^3 + O(q^4),
     q - 3/(64*d)*q^2 - 4863/(262144*d^2)*q^3 + O(q^4),
     q - 27/(64*d)*q^2 + 17217/(262144*d^2)*q^3 + O(q^4)]
Got:
    [q + (17535/(-262144*d^2))*q^3 + O(q^4),
     q^2 - 47/(128*d)*q^3 + O(q^4),
     q + (9/(-128*d))*q^2 + (-15633/(-262144*d^2))*q^3 + O(q^4),
     q^2 - 7/(128*d)*q^3 + O(q^4),
     q - 23/(64*d)*q^2 - 3103/(262144*d^2)*q^3 + O(q^4),
     q - 3/(64*d)*q^2 - 4863/(262144*d^2)*q^3 + O(q^4),
     q - 27/(64*d)*q^2 + 17217/(262144*d^2)*q^3 + O(q^4)]
**********************************************************************
File "src/sage/modular/modform_hecketriangle/space.py", line 817, in sage.modular.modform_hecketriangle.space.CuspForms.gens
Failed example:
    MF.gens()
Expected:
    [q + 296888795/(10319560704*d^3)*q^4 + O(q^5),
     q^2 + 6629/(221184*d^2)*q^4 + O(q^5),
     q^3 - 25/(96*d)*q^4 + O(q^5)]
Got:
    [q + 296888795/(10319560704*d^3)*q^4 + O(q^5),
     q^2 + (-6629/(-221184*d^2))*q^4 + O(q^5),
     q^3 - 25/(96*d)*q^4 + O(q^5)]
**********************************************************************

Additional Information

Why plus/minus signs are not simplified in fractions?

The text was updated successfully, but these errors were encountered:

jhpalmieri · 2023-03-15T01:54:17Z

I see this with 10.0.beta4 but not 10.0.beta2 (both built today on the same machine), so it's not caused by recent homebrew upgrades, for example. (Unless I'm confused, which is certainly possible.)

jhpalmieri · 2023-03-16T17:58:44Z

Perhaps caused by #35045.

jhpalmieri · 2023-03-20T22:30:13Z

I tried with a linux virtual machine and doctests passed, so somehow it seems to be platform-dependent.

jhpalmieri · 2023-03-20T22:30:42Z

Marking as a blocker since we get failing doctests.

mezzarobba · 2023-03-21T09:00:40Z

(Replying to #35045 (comment):)

I don't see how something like that can be platform-dependent. Have you compared the parents of the output on Linux and OSX, or checked if manually created expressions in the same parent failed to simplify too?

jhpalmieri · 2023-03-21T15:19:35Z

I don't know the mathematics, so I don't know what to try. If I do a = MF.F_basis(1), then parent(a) and type(a) are the same on OS X and Linux, but their print representations are different. If you have access to an OS X machine, you can see this with 10.0.beta4 or later. The doctest failures are not there in 10.0.beta3, but they are after applying https://patch-diff.githubusercontent.com/raw/sagemath/sage/pull/35045.diff.

jhpalmieri · 2023-03-21T15:20:13Z

Maybe there is some different system package, and this behavior is revealing that difference somehow.

mezzarobba · 2023-03-21T15:52:39Z

If I do a = MF.F_basis(1), then parent(a) and type(a) are the same on OS X and Linux, but their print representations are different.

What about the parent of a.q_expansion()? Is it Power Series Ring in q over Fraction Field of Univariate Polynomial Ring in d over Integer Ring as on Linux, or something different (e.g., ... over RationalField)? How do the print representations of manually created elements of that parent look like? of its base ring?

jhpalmieri · 2023-03-21T16:09:06Z

For both platforms, I see the same behavior:

sage: R = parent(a.q_expansion())
sage: R
sage: R.base_ring().inject_variables()
Defining d
sage: R(1/(-d))
1/-d

sage: R.inject_variables()
Defining q
sage: q + (13071/(-640000*d^2))*q^3
q + (13071/(-640000*d^2))*q^3

At least on OS X I see the same behavior in vanilla 10.0.beta3 — without the branch at #35045. (I haven't tried on linux.)

jhpalmieri · 2023-03-21T21:13:21Z

The behavior looks very strange to me, even before #35045. With 10.0.beta3:

sage: from sage.modular.modform_hecketriangle.space import WeakModularForms, CuspForms
sage: MF = WeakModularForms(n=5, k=62/3, ep=-1)
sage: a = MF.F_basis(1)
sage: a
q - 13071/(640000*d^2)*q^3 - 26203/(1500000*d^3)*q^4 + O(q^5)
sage: R = parent(a.q_expansion())
sage: R.inject_variables()
Defining q
sage: R.base_ring().inject_variables()
Defining d

sage: q - 13071/(640000*d^2)*q^3 - 26203/(1500000*d^3)*q^4 + O(q^5)
q - 13071/(640000*d^2)*q^3 - 26203/(1500000*d^3)*q^4 + O(q^5)
sage: q + (13071/(-640000*d^2))*q^3 + (26203/(-1500000*d^3))*q^4 + O(q^5)
q + (13071/(-640000*d^2))*q^3 + (26203/(-1500000*d^3))*q^4 + O(q^5)

The last two expressions evaluate as equal, so why don't they print the same way? Maybe #35045 just changed how the expression is defined, from something along the lines of q - A/B to q + A/(-B), and this catches an apparently old behavior that the signs are not simplified to convert the second form to the first.

jhpalmieri · 2023-03-22T00:25:11Z

Maybe it's Singular. When I use ./configure --with-system-singular=no, tests pass. On OS X, Homebrew includes Singular 4.3.2, whereas Sage includes 4.3.1.

mezzarobba · 2023-03-22T07:35:04Z

The last two expressions evaluate as equal, so why don't they print the same way?

~~Sounds like #35221 (comment), but I don't understand why the issue occurs on some systems only then.~~ (Edit: I had missed your comment about singular.)

Maybe #35045 just changed how the expression is defined

Yes, most probably.

mezzarobba · 2023-03-22T07:38:19Z

Maybe it's Singular. When I use ./configure --with-system-singular=no, tests pass. On OS X, Homebrew includes Singular 4.3.2, whereas Sage includes 4.3.1.

Ok: not a bug, then?

jhpalmieri · 2023-03-22T16:05:10Z

It causes doctests to fail, so it needs to be fixed.

mezzarobba · 2023-03-22T16:19:14Z

Maybe... It is quite common to see a few failing doctests when using system packages for dependencies like pari, gap, or singular. I tend to view that as normal, though I agree that ideally it should be fixed (if we can do it by adapting the code or the tests, not by restricting the range of allowed versions of the dependency when the version for which the tests fail works fine otherwise).

GMS103 · 2023-03-22T16:27:13Z

Whatever the cause, I do not see any reason to get
q + (13071/(-640000*d^2))*q^3 + O(q^4)
instead of
q - 13071/(640000*d^2)*q^3 + O(q^4).
This seems to me incoherent (when compared for instance with q^2 - 47/(128*d)*q^3 + O(q^4)).
Is it difficult to correct?

mezzarobba · 2023-03-22T18:56:36Z

Is it difficult to correct?

Even if the difference in behavior between systems observed here is due to different versions of Singular, the fact that fractions are not normalized as one would expect looks a lot like the issue discussed in #35221 (comment).

jhpalmieri · 2023-03-22T20:35:38Z

A potential fix: replace doctests like

sage: MF.F_basis(1)
q - 13071/(640000*d^2)*q^3 + O(q^4)

with

sage: MF.F_basis(1) == q - 13071/(640000*d^2)*q^3 + O(q^4)
True

(Probably have to inject some variables first so that the right side is defined.) This is not altogether satisfying because I agree that we should see - 13071/(640000*d^2) rather than 13071/(-640000*d^2). But it would test the mathematics correctly.

jhpalmieri · 2023-04-14T03:50:32Z

I tried creating some doctests of the form I mentioned in the previous comment, but I was unsuccessful. If someone else wants to try, I'm happy to test.

vbraun · 2023-05-14T08:57:52Z

The doctests all have properly normalized fractions, so the fact that they aren't is imho indicative of a bigger problem and we shouldn't "fix" it by allowing the wrong normalization. We do have multiple OSX buildbots and they don't reproduce the issue, so its a Singular 4.3.2 bug or a bug in homebrew's packaging. Either way, it shouldn't block us from making a release.

mezzarobba · 2023-05-14T09:17:44Z

This is just a guess, but I think: (1) there is a bigger problem, namely that rational fractions are not properly normalized in Sage in general; (2) but that problem is known and documented in other issues and the fact that it pops up here is an accident.

jhpalmieri · 2023-06-22T18:41:32Z

Should we disallow this version of the system Singular?

GMS103 · 2023-07-09T21:12:02Z

This issue seems related to Homebrew's Singular version 4.3.2p2, as it does not appear with Singular SPKG version 4.3.1p3. See #35833.

mkoeppe · 2023-07-11T19:42:53Z

The same version built from the updated SPKG (#35934) passes the tests.

The difference with the homebrew formula https://github.com/Homebrew/homebrew-core/blob/master/Formula/singular.rb#L56 is that we build Singular with FLINT.

mkoeppe · 2023-07-11T20:12:44Z

We could for example reject system singular if it does not use FLINT.
that's HAVE_FLINT in <singular/singularconfig.h>

Done now in #35934

mkoeppe · 2023-07-11T20:21:14Z

Upstream does not test configurations without FLINT, it seems: https://github.com/Singular/Singular/blob/spielwiese/.github/workflows/runtests.yml#L15

jhpalmieri · 2023-07-31T18:41:42Z

The same version built from the updated SPKG (#35934) passes the tests.

The difference with the homebrew formula https://github.com/Homebrew/homebrew-core/blob/master/Formula/singular.rb#L56 is that we build Singular with FLINT.

Does anyone here know anything about homebrew's development process? Would they be receptive to a pull request to bulid with FLINT?

GMS103 added the t: bug label Mar 13, 2023

jhpalmieri added the p: blocker / 1 label Mar 20, 2023

jhpalmieri mentioned this issue Mar 20, 2023

Convert result of multivariate polynomial evaluation into correct parent #35045

Merged

vbraun removed the p: blocker / 1 label May 14, 2023

jhpalmieri mentioned this issue Jun 22, 2023

update Singular spkg to 4.3.2+ #35676

Closed

1 task

mkoeppe added the c: modular forms label Jul 1, 2023

jhpalmieri mentioned this issue Jul 9, 2023

macos: Singular issues (version 4.3.2p2 from Homebrew) #35833

Closed

2 tasks

vbraun closed this as completed in bfb6b3c Sep 1, 2023

mkoeppe added this to the sage-10.2 milestone Sep 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failing doctests in src/sage/modular/modform_hecketriangle #35273

Failing doctests in src/sage/modular/modform_hecketriangle #35273

GMS103 commented Mar 13, 2023

jhpalmieri commented Mar 15, 2023 •

edited

Loading

jhpalmieri commented Mar 16, 2023 •

edited

Loading

jhpalmieri commented Mar 20, 2023

jhpalmieri commented Mar 20, 2023

mezzarobba commented Mar 21, 2023

jhpalmieri commented Mar 21, 2023

jhpalmieri commented Mar 21, 2023

mezzarobba commented Mar 21, 2023

jhpalmieri commented Mar 21, 2023

jhpalmieri commented Mar 21, 2023

jhpalmieri commented Mar 22, 2023

mezzarobba commented Mar 22, 2023 •

edited

Loading

mezzarobba commented Mar 22, 2023

jhpalmieri commented Mar 22, 2023

mezzarobba commented Mar 22, 2023

GMS103 commented Mar 22, 2023

mezzarobba commented Mar 22, 2023

jhpalmieri commented Mar 22, 2023 •

edited

Loading

jhpalmieri commented Apr 14, 2023

vbraun commented May 14, 2023

mezzarobba commented May 14, 2023

jhpalmieri commented Jun 22, 2023

GMS103 commented Jul 9, 2023

mkoeppe commented Jul 11, 2023

mkoeppe commented Jul 11, 2023 •

edited

Loading

mkoeppe commented Jul 11, 2023

jhpalmieri commented Jul 31, 2023

Failing doctests in src/sage/modular/modform_hecketriangle #35273

Failing doctests in src/sage/modular/modform_hecketriangle #35273

Comments

GMS103 commented Mar 13, 2023

Is there an existing issue for this?

Did you read the documentation and troubleshoot guide?

Environment

Steps To Reproduce

Expected Behavior

Actual Behavior

Additional Information

jhpalmieri commented Mar 15, 2023 • edited Loading

jhpalmieri commented Mar 16, 2023 • edited Loading

jhpalmieri commented Mar 20, 2023

jhpalmieri commented Mar 20, 2023

mezzarobba commented Mar 21, 2023

jhpalmieri commented Mar 21, 2023

jhpalmieri commented Mar 21, 2023

mezzarobba commented Mar 21, 2023

jhpalmieri commented Mar 21, 2023

jhpalmieri commented Mar 21, 2023

jhpalmieri commented Mar 22, 2023

mezzarobba commented Mar 22, 2023 • edited Loading

mezzarobba commented Mar 22, 2023

jhpalmieri commented Mar 22, 2023

mezzarobba commented Mar 22, 2023

GMS103 commented Mar 22, 2023

mezzarobba commented Mar 22, 2023

jhpalmieri commented Mar 22, 2023 • edited Loading

jhpalmieri commented Apr 14, 2023

vbraun commented May 14, 2023

mezzarobba commented May 14, 2023

jhpalmieri commented Jun 22, 2023

GMS103 commented Jul 9, 2023

mkoeppe commented Jul 11, 2023

mkoeppe commented Jul 11, 2023 • edited Loading

mkoeppe commented Jul 11, 2023

jhpalmieri commented Jul 31, 2023

jhpalmieri commented Mar 15, 2023 •

edited

Loading

jhpalmieri commented Mar 16, 2023 •

edited

Loading

mezzarobba commented Mar 22, 2023 •

edited

Loading

jhpalmieri commented Mar 22, 2023 •

edited

Loading

mkoeppe commented Jul 11, 2023 •

edited

Loading