Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on "Generation of trees" is incomplete #39180

Open
2 tasks done
maxale opened this issue Dec 21, 2024 · 5 comments
Open
2 tasks done

Documentation on "Generation of trees" is incomplete #39180

maxale opened this issue Dec 21, 2024 · 5 comments

Comments

@maxale
Copy link
Contributor

maxale commented Dec 21, 2024

Steps To Reproduce

There exist at least 3 methods of trees generation in Sage:

  • via sage.graphs.trees.TreeIterator()
  • via graphs.trees()
  • via graphs.nauty_gentreeg()

Expected Behavior

Documentation at https://doc.sagemath.org/html/en/reference/graphs/sage/graphs/trees.html should mention all available methods, and possibly explain differences between them.

Actual Behavior

Only the first method is described.

Additional Information

No response

Environment

  • OS: N/A
  • Sage Version: 10.6.beta1

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@maxale maxale added the t: bug label Dec 21, 2024
@PrashantChoudhary13579
Copy link

Hello sir,
Please assign this task to me as i want to do something for this organisation.

@DaveWitteMorris
Copy link
Member

See "Various families of graphs" for the documentation of graphs.nauty_gentreeg and graphs.trees. It does seem like a good idea to mention these under "Generation of trees"

@PrashantChoudhary13579
Copy link

OK sir,
Thank you sir for providing the information. I will go through them.

@DaveWitteMorris
Copy link
Member

PS I think you should be able to assign yourself to this task. Are you unable to do that from some reason? (Also, being assigned to a task is not required in order to work on it. However, it's a good idea because it can avoid wasted effort by dissuading anyone else from working on it at the same time.)

@maxale
Copy link
Contributor Author

maxale commented Dec 22, 2024

It does seem like a good idea to mention these under "Generation of trees"

I consider "Generation of trees" as an entry point to the subject, and this is where anyone searching for how to generate trees in Sage will likely end up. So, either it should be comprehensive about various ways of generating trees in Sage, or should be renamed to something more specific like "Generation of trees with TreeIterator" or alike. I like the former option better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants