Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Rising Factorial #39409

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

harith-hacky03
Copy link

Fixes Rising Factorial

Fixed Rising Factorial Function Implementation.

Fixes #39406

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729
Copy link
Contributor

Can you add a test for this? (such that the test fails before the change, of course)

@harith-hacky03
Copy link
Author

@user202729 so basically you want me to add the test cases and before and after input and output, am I right buddy?

@vincentmacri
Copy link
Contributor

@user202729 so basically you want me to add the test cases and before and after input and output, am I right buddy?

@user202729 is referring to this from the developer guide:

Bugfixes: If the PR contains a bugfix, does it add a doctest illustrating that the bug has been fixed? This new doctest should contain the issue or PR number, for example See :issue:12345.

@vincentmacri
Copy link
Contributor

vincentmacri commented Jan 30, 2025

* [x]  I have created tests covering the changes.

* [x]  I have updated the documentation and checked the documentation preview.

You didn't add any tests or change the documentation yet. Please do not mark these tasks as being done until you've completed them. And for future contributions, not all of these are relevant for every PR. You only need to check off the items relevant to the PR, and you should not check them off until you've completed them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong subs in rising_factorial
3 participants