-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all occurrences of "method" to "algorithm" in coding/code_bounds.py #7971
Comments
comment:1
This patch will build, and the tests in sage/coding all pass. But I don't have Guava installed, which is needed for most of the affected doctests. David - maybe you can run the optional tests as part of a review? |
Author: Rob Beezer |
Attachment: trac_7971_method_algorithm.patch.gz |
comment:3
Passes all doctests on Sage 4.3.1.rc0 with or without the patch. To run the optional doctests that require Guava: After applying the patch, install the optional Guava package by installing the package gap_packages-4.4.10_6.spkg. Running doctest on "sage/coding/code_bounds.py" with the options
results in all doctests passed. Positive review. |
Reviewer: Minh Van Nguyen |
comment:4
This needs work (deprecation warnings) and so should just be handled as part of #6094. I've marked this as "needs work" but should be marked some form of invalid. |
comment:5
The currently newest uploaded patch for Trac #6094 -- needing a positive review -- handles all these cases, so this Trac should just be closed. |
This is a follow-on to #6094. More places where the keyword argument "method=" should be changed to "algorithm=".
CC: @wdjoyner
Component: coding theory
Author: Rob Beezer
Reviewer: Minh Van Nguyen
Issue created by migration from https://trac.sagemath.org/ticket/7971
The text was updated successfully, but these errors were encountered: