Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all occurrences of "method" to "algorithm" in coding/code_bounds.py #7971

Closed
rbeezer mannequin opened this issue Jan 18, 2010 · 7 comments
Closed

Change all occurrences of "method" to "algorithm" in coding/code_bounds.py #7971

rbeezer mannequin opened this issue Jan 18, 2010 · 7 comments

Comments

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jan 18, 2010

This is a follow-on to #6094. More places where the keyword argument "method=" should be changed to "algorithm=".

CC: @wdjoyner

Component: coding theory

Author: Rob Beezer

Reviewer: Minh Van Nguyen

Issue created by migration from https://trac.sagemath.org/ticket/7971

@rbeezer rbeezer mannequin added this to the sage-4.6.1 milestone Jan 18, 2010
@rbeezer rbeezer mannequin added c: coding theory labels Jan 18, 2010
@rbeezer rbeezer mannequin assigned wdjoyner Jan 18, 2010
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jan 18, 2010

comment:1

This patch will build, and the tests in sage/coding all pass. But I don't have Guava installed, which is needed for most of the affected doctests.

David - maybe you can run the optional tests as part of a review?

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jan 18, 2010

Author: Rob Beezer

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jan 18, 2010

Attachment: trac_7971_method_algorithm.patch.gz

@rbeezer rbeezer mannequin added the s: needs review label Jan 18, 2010
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 18, 2010

comment:3

Passes all doctests on Sage 4.3.1.rc0 with or without the patch. To run the optional doctests that require Guava: After applying the patch, install the optional Guava package by installing the package gap_packages-4.4.10_6.spkg. Running doctest on "sage/coding/code_bounds.py" with the options

-t -long -optional

results in all doctests passed. Positive review.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 18, 2010

Reviewer: Minh Van Nguyen

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jan 18, 2010

comment:4

This needs work (deprecation warnings) and so should just be handled as part of #6094.

I've marked this as "needs work" but should be marked some form of invalid.

@rbeezer rbeezer mannequin added s: needs work and removed s: positive review labels Jan 18, 2010
@johanrosenkilde
Copy link
Contributor

comment:5

The currently newest uploaded patch for Trac #6094 -- needing a positive review -- handles all these cases, so this Trac should just be closed.

@rlmill rlmill mannequin added r: duplicate and removed p: minor / 4 labels Nov 9, 2010
@rlmill rlmill mannequin closed this as completed Nov 9, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin removed this from the sage-4.6.1 milestone Nov 9, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants