Cleanup of crystal code

[jbandlow]

Fixed some issues in crystals, such as

• Comparison of elements
• Latex output
• Fixes whitespaces in /combinat/crystals/affine.py (as reported by Jason Bandlow)
• All crystals have unique representation
• Preparation of categorification of crystals:
  • C.element_class -> C.Element
  • All crystals are at least in the EnumeratedSets category
  • Use rename, or define _repr_, instead of setting _name
    Eventually, crystals should only use _repr_
    => Removed dependency upon deprecated CombinatorialClass
• Systematic use of TestSuite instead of loads/dumps test
• Fixed bug in fast_crystal: delpat is not immutable (which should be
  eventually be fixed), and was accidentally changed by the weight
  method). This was caught by turning on unique representation which
  made the crystals to be reused longer in the tests.

Depends on #8028 (element wrapper improvement)

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: crystals

Author: Nicolas M. Thiéry, Anne Schilling

Reviewer: Dan Bump

Merged: sage-4.3.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7978

[jbandlow]

comment:1

Attachment: trac_7978_fix_tabs_in_affine_py-jb.patch.gz

Oops. This patch depends on some patches in the combinat stack. (I suspect the 'crystal-cleanup' patches.) The change is trivial, but I'll coordinate with the sage-combinat list before marking this ready for review.

[anneschilling]

Attachment: trac_7978_crystal_cleanup-as.patch.gz

[anneschilling]

comment:2

The patch trac_7978_crystal_cleanup-as.patch supersedes Jason's patch. It fixes the whitespace issues in combinat/crystals/affine.py and does a lot more improvements in crystals (see description).

[anneschilling]

Changed keywords from none to crystals

[anneschilling]

Author: Nicolas M. Thiery, Anne Schilling

[anneschilling]

Reviewer: Dan Bump

[nthiery]

Changed author from Nicolas M. Thiery, Anne Schilling to Nicolas M. Thiéry, Anne Schilling

[nthiery]

Updated patch updates one doctest.

[dwbump]

comment:4

Attachment: trac_7978_crystal_cleanup-as.2.patch.gz

I checked that the patch passes sage --testall, either with or without #8028.

I checked that it does not break latex method for classical crystals or metapost method for fastcrystals. I think the latex changes are specific to
affine crystals.

The patch does not seem to break anything, and fixes some problems. I recommend merging it.

[qed777]

comment:5

I've added the ticket number in the refreshed patch I'm applying to 4.3.3.alpha0.

[dwbump]

comment:6

I'm having trouble parsing mpatel's message. Does this mean the patch is to be merged in 4.3.3.alpha0?

What "refreshed patch" does this message refer to? The patch trac_7978_crystal_cleanup-as.2.patch
applies cleanly to sage-4.3.2 and does not break anything in sage/combinat/crystals.

[qed777]

comment:7

I'll merge this ticket into 4.3.3.alpha0. I mean only that I've prepended the ticket number to the first line of the commit string of the patch I've added to my working tree for 4.3.3.alpha0. I apologize for being so cryptic.

[qed777]

Merged: sage-4.3.3.alpha0