Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab completion broken for many parent objects #8223

Closed
williamstein opened this issue Feb 9, 2010 · 9 comments
Closed

tab completion broken for many parent objects #8223

williamstein opened this issue Feb 9, 2010 · 9 comments

Comments

@williamstein
Copy link
Contributor

sage: P.<x,y> = QQ[]
sage: dir(P)
BOOM!

This is caused by Nick Thiery's patch from trac #7921 which very badly defines a __dir__ method for parents:

changeset:   13746:6ad207aca83f
user:        Nicolas M. Thiery <nthiery@users.sf.net>
date:        Fri Jan 22 22:53:29 2010 +0100          
summary:     #7921: Categories for extension types via __getattr___

The problem was reported at this sage-devel thread.

CC: @novoselt

Component: misc

Author: Nicolas M. Thiéry

Reviewer: Andrey Novoseltsev

Merged: sage-4.3.3.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/8223

@williamstein

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Feb 9, 2010

Author: Nicolas M. Thiéry

@nthiery nthiery self-assigned this Feb 9, 2010
@nthiery
Copy link
Contributor

nthiery commented Feb 9, 2010

comment:3

Attachment: trac_8223-fix_dir-nt.patch.gz

The attached patch should fix the issue. That being said, I would love to see a more robust implementation of sage.structure.parent.dir_with_other_class.

@sagetrac-mvngu

This comment has been minimized.

@haraldschilly
Copy link
Member

comment:5

on #sage-devel

00:39 < logix> fwiw, for me the patch in #8223 makes k.[TAB] work again (where e.g. k.<a>=GF(8) )

@novoselt
Copy link
Member

comment:8

Looks good to me.

@novoselt
Copy link
Member

Reviewer: Andrey Novoseltsev

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 17, 2010

Merged: sage-4.3.3.alpha1

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 17, 2010

comment:9

Merged trac_8223-fix_dir-nt.patch with a sensible commit message containing the ticket number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants