Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for elements of a root lattice and related features and fixes #8811

Closed
anneschilling opened this issue Apr 28, 2010 · 11 comments
Closed

Comments

@anneschilling
Copy link

This patch implements translation for elements of a root lattice and related features and fixes::

  • New method translation for elements of a root lattice

  • New methods reduced_word_of_alcove_morphism, dynkin_diagram_automorphism_of_alcove_morphism, reduced_word_of_translation, _test_reduced_word_of_translation

  • Added extensive TESTS to compare with Kashiwara's private notes

  • Fixed dynkin diagram for type BC

  • Fixed CartanType.translation_factors to implement its specification correctly in affine type BC. Imported the full test suite from MuPAD-Combinat. Also fixes and tests for proper typing of the coefficients (ZZ/QQ).

  • Bug fix in WeylGroup: the matrices were defined over QQ instead of the base ring of the underlying root lattice realization.

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: root systems, affine weyl groups, translations

Author: Nicolas M. Thiéry

Reviewer: Anne Schilling

Merged: sage-4.4.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8811

@nthiery
Copy link
Contributor

nthiery commented May 21, 2010

Changed keywords from none to root systems, affine weyl groups, translations

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented May 21, 2010

Reviewer: Anne Schilling, ...

@nthiery nthiery added this to the sage-4.4.3 milestone May 21, 2010
@nthiery

This comment has been minimized.

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Jun 2, 2010

comment:4

Attachment: trac_8811_reduced_word_of_translations-nt.patch.gz

@nthiery

This comment has been minimized.

@nthiery nthiery changed the title Translation for elements of a root lattice Translation for elements of a root lattice and related features and fixes Jun 2, 2010
@anneschilling
Copy link
Author

comment:5

I carefully checked the results of translation_factor, adding extra tests to compare with Kashiwara's private notes. Nicolas and I discussed at length the correct factors for type BC (see the corresponding doc in the code).

All tests passed on massena and all tests in combinat/root_systems passed on my machine.

Positive review.

@anneschilling
Copy link
Author

Changed reviewer from Anne Schilling, ... to Anne Schilling

@mwhansen
Copy link
Contributor

mwhansen commented Jun 5, 2010

Merged: sage-4.4.4.alpha0

@mwhansen
Copy link
Contributor

mwhansen commented Jun 7, 2010

Changed author from Nicolas M. Thiery to Nicolas M. Thiéry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants