Clean up and add functions to sage/libs/pari/decl.pxi

[jdemeyer]

• Adds a file sage/libs/pari/declinl.pxi for declarations of inline functions (which is included by sage/libs/pari/decl.pxi).
• Some clean up of sage/libs/pari/decl.pxi, in particular removing duplicate functions.
• Adds/updates authors sections.

CC: @nexttime

Component: interfaces

Author: Jeroen Demeyer

Reviewer: Leif Leonhardy

Merged: sage-4.6.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/9898

[nexttime]

comment:3

s/seperate/separate/

s/This files/This file/

[jdemeyer]

comment:4

Replying to @nexttime:

s/seperate/separate/

s/This files/This file/

Done.

[nexttime]

comment:5

Did you upload the wrong patch?

I just noticed the typos are back...

[nexttime]

comment:6

The global t0 in gequal_long() is superfluous.

[jdemeyer]

Author: Jeroen Demeyer

[jdemeyer]

comment:7

Attachment: 9898_pari_decl.patch.gz

Done.

[nexttime]

comment:8

Ok, I've now also tested this with Sage 4.6.alpha1 and #9876 (PARI 2.4.3.svn-12577.p7) on Ubuntu 9.04 x86 and Ubuntu 10.04 x86_64 (both ptestlong).

Patch is up-to-date, so positive review.

I've (of course?) not checked if all functions really come from the PARI source files they're claimed to come from. ;-)

It's up to you to convince Mitesh to merge it into 4.6.alpha2. :)

[nexttime]

Reviewer: Leif Leonhardy

[nexttime]

comment:10

Perhaps one should mention that pari/declinl.pxi gets included by pari/decl.pxi.

Add svn snapshot number?

[jdemeyer]

Adds authors to files in sage/libs/pari, apply on top of 9898_pari_decl.patch

[jdemeyer]

comment:11

Attachment: 9898_authors.patch.gz

Replying to @nexttime:

Perhaps one should mention that pari/declinl.pxi gets included by pari/decl.pxi.

Done.

Add svn snapshot number?

I don't think that is so relevant (those files would not look that much different for other SVN snapshot numbers). Besides, people can still look at the ticket #9343 for more information.

[nexttime]

comment:12

Replying to @jdemeyer:

[...] people can still look at the ticket #9343 for more information.

:-)

Btw, is 08-15 a symbolic date?

Positive review for the second patch, too.

[qed777]

Merged: sage-4.6.alpha2