Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable Pluto.jl upgrade message #6212

Closed
williamstein opened this issue Nov 11, 2022 · 7 comments
Closed

disable Pluto.jl upgrade message #6212

williamstein opened this issue Nov 11, 2022 · 7 comments

Comments

@williamstein
Copy link
Contributor

See fonsp/Pluto.jl#2364 (comment)

Basically the current message doesn't convey the right information to users of Pluto.jl in a managed service, since they don't have the ability to upgrade anyways.

We have had (and maybe still have) this same problem with JupyterLab and JupyterLab extensions. Frederic Collonval (QuantStack | @fcollonval ) just demoed in the last JupyterLab meeting a new feature that will definitely introduce exactly this problem in the future as well for JupyterLab. So keep an eye on that as well. I wish I could tag @fcollonval on this message somehow.

@williamstein
Copy link
Contributor Author

They are very open to a PR that stats the files where Pluto.jl is installed and if the user doesn't have write permissions maybe doesn't show the upgrade dialog.

@fcollonval
Copy link

Thanks William for the ping. For JupyterLab, the request to the third party service will be done by the server. That part of the server is customizable and an alternative plugin not looking for updates will be available (although it won't be the default).

Regarding privacy, the server will do the request following a request from a plugin frontend. Administrators can disable that specific plugin if they want. And the user must explicitly agree for the frontend to trigger the request chain that will interrogate the third party service.

@williamstein
Copy link
Contributor Author

@fcollonval Thanks!!

@williamstein
Copy link
Contributor Author

for now, probably the easiest way to "fix" this for pluto is just to upgrade pluto. @haraldschilly ?

@jasongrout
Copy link
Contributor

Also, IIRC, the url to check for updates is customizable in the settings, which means that a site administrator can configure the default url with site overrides for the default plugin settings. Is that right, @fcollonval?

@fcollonval
Copy link

Also, IIRC, the url to check for updates is customizable in the settings, which means that a site administrator can configure the default url with site overrides for the default plugin settings. Is that right, @fcollonval?

Yes indeed - the configuration available is described in the documentation

@williamstein
Copy link
Contributor Author

I'm closing this since users just ignore such messages and it seems they don't care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants