Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types packet for txikijs #390

Closed
lal12 opened this issue Sep 15, 2023 · 3 comments
Closed

@types packet for txikijs #390

lal12 opened this issue Sep 15, 2023 · 3 comments

Comments

@lal12
Copy link
Contributor

lal12 commented Sep 15, 2023

I would propose creating @types/txikijs npm package containing the txikijs.d.ts, if they are allow. Haven't looked into their guidelines yet.

Alternatively creating just a txikijs-types package, but this isn't picked up by default and needs an import.

Could do a PR and publish it, depending on what you want @saghul ?

@saghul
Copy link
Owner

saghul commented Sep 15, 2023

Sounds good! Perhaps @txikijs/types would make sense?

@lal12
Copy link
Contributor Author

lal12 commented Sep 15, 2023

I looked into it a bit more, while DefinitelyTyped (@types/* packages) would be the easiest (npm install & done) solution, it would either require to maintain definitions in their repo or to sync it, but this most likely not worth the hassle.

So I am doing a PR with a new package, this then can be imported import type from '@txikijs/types'; or specified in the typeRoots property in tsconfig.json

@lal12
Copy link
Contributor Author

lal12 commented Sep 15, 2023

See #391

@lal12 lal12 closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants