Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Integration into conda environment #1119

Closed
MementoRC opened this issue Jul 19, 2024 · 7 comments
Closed

Minor: Integration into conda environment #1119

MementoRC opened this issue Jul 19, 2024 · 7 comments
Assignees

Comments

@MementoRC
Copy link

Describe The Bug

We have a conda-forge recipe for cargo-make: https://github.com/conda-forge/cargo-make-feedstock
The latest update broke one of the simplistic tests we performed on the built package: cargo-make --help (makers --help sitll works) for every releases. For now we have commentted out the test to continue provide the up-to-date package. It would be great if you could confirm that the behavior is discontinued, or could suggest a simple test to validate the correct behavior of cargo-make within the conda environment

To Reproduce

cargo-make --help

Error Stack

+ cargo-make -h
`cliparser::types::ParserError` error. InvalidCommandLine("Command does not match spec, command line: [\"cargo-make\", \"-h\"]")
exit code 731
@MementoRC
Copy link
Author

MementoRC commented Jul 19, 2024

If you wish to be added to the list of maintainer, please submit an issue:
https://github.com/conda-forge/cargo-make-feedstock/issues/new?assignees=&labels=&projects=&template=2-bot-commands.yml
with:
@conda-forge-admin, please add user @sagiegurari

@sagiegurari
Copy link
Owner

thanks for reporting. my guess its related to #1112 by @SamuelMarks
if he can solve it, amazing. if not, unfortunately I won't have availability for coming 2 weeks :( and than I'll be able to check it out.

@SamuelMarks
Copy link
Contributor

SamuelMarks commented Jul 19, 2024

Yes I'll take a look at the --version and --help flags when I get back (getting ☕ now)


Update 0: it breaks here https://github.com/sagiegurari/cliparser/blob/e8f2bfb/src/parser.rs#L169

Might need to send that project of yours a PR


Update 1: Sent through this simple change, tell me if it resolves your issue @MementoRC sagiegurari/cliparser#3


Update 2: Actually @MementoRC now that my #1120 is merged everything might work, try pointing to cargo-make@master


Update 3: Hmmm

$ makers --version
cargo-make 0.37.14
$ cargo make --version
cargo-make 0.37.14
$ cargo-make --version
`cliparser::types::ParserError` error. InvalidCommandLine("Command does not match spec, command line: [\"cargo-make\", \"--version\"]")
exit code 731

@MementoRC
Copy link
Author

Thanks for the updates. conda-forge recipe builds on top of official releases or tags and we allowed the latest version to go live based upon your initial response. We will revisit at the next release

@sagiegurari
Copy link
Owner

@MementoRC sorry didn't have a computer available for a while. going back to this it seems odd it ever worked for you. probably some bug.

there are 3 ways to run cargo make

  1. makers
  2. cargo make
  3. cargo-make make # this one basically because how 'cargo' works

its strange it worked differently. 2 and 3 are for cargo integration so its always a sub command while the first is standalone so it doesn't need the 'extra' make sub command.

can you change the test to: cargo-make make -h instead?

@MementoRC
Copy link
Author

Ok, I will try it with the new release

@MementoRC
Copy link
Author

All good. Released. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants