Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the initialization of sampling_offsets #21

Open
Mayy1994 opened this issue Jul 19, 2022 · 0 comments
Open

Question about the initialization of sampling_offsets #21

Mayy1994 opened this issue Jul 19, 2022 · 0 comments

Comments

@Mayy1994
Copy link

Dear authors,

In lib.models/ops/modules/projattn.py, I noticed that the weights of self.sampling_offsets is set to constant 0, and the bias has no gradient backpropagation (line 94- line 105).

def _reset_parameters(self):

屏幕快照 2022-07-19 下午3 51 07

In my opinion, if the weights are set to 0 and the bias has no gradient, the sampled offsets will be always the same across different training samples. But it seems the offsetted points are informatively selected according to Figure 5 in your paper.

On the other hand, in the provided pretrained model, the weights and the bias are different from what they are initialized.
Could you please tell me what is the final initialization method of self.sampling_offsets?
Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant