Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESR 91 rendering pipeline #1020

Closed
llewelld opened this issue Oct 3, 2023 · 1 comment
Closed

Fix ESR 91 rendering pipeline #1020

llewelld opened this issue Oct 3, 2023 · 1 comment
Assignees
Labels
esr91 Changes required to support Gecko ESR 91
Milestone

Comments

@llewelld
Copy link
Member

llewelld commented Oct 3, 2023

The rendering pipeline has changed significantly between ESR 78 and ESR 91. The GLES rendering code was removed and switched for a Web Render pipeline instead.

Some of the relevant upstream changes include the following:

  1. Support for multiple EglDisplays: D85496. The EglDisplay is passed in from QtMozEmbed, so this causes some problems.
  2. Out of process WebGL compositing: D75055. This removes GLSCreenBuffer completely in favour of a new much sparser SwapChain. This really messes up our renderer.

See for example:

  1. 51e18eb9b16ee94a775d3d4f1f333c11e306368e.
  2. d59d44a5bccafc714a2e380197c8cb9334107eb1.
@llewelld llewelld added the esr91 Changes required to support Gecko ESR 91 label Oct 3, 2023
@llewelld llewelld added this to the esr91 milestone Oct 3, 2023
@llewelld llewelld self-assigned this Oct 4, 2023
@llewelld
Copy link
Member Author

The rendering pipeline has now been fixed (both the browser and offscreen pipelines) by the following commits in the sailfishos-esr91 branch:

1765dd0460a9 Restore GLScreenBuffer and TextureImageEGL
d3ba4df29a32 Restore NotifyDidPaint event and timers

This has been tested on multiple Xperia devices, but crucially not on the emulator or a native device, which I suspect will still be broken. Since we have #1043 to cover the native case, I'm closing this issue as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esr91 Changes required to support Gecko ESR 91
Projects
None yet
Development

No branches or pull requests

1 participant