Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #31

Merged
merged 5 commits into from
Feb 19, 2022
Merged

Improve logging #31

merged 5 commits into from
Feb 19, 2022

Conversation

Blarkdackbyte
Copy link
Contributor

@Blarkdackbyte Blarkdackbyte commented Feb 4, 2022

Hi!
I implemented the feature request from #30 with the help of its creator https://github.com/kaerbr :)

This pull request contains the following changes:

  • Refactor: Rename getStagedFiles to getModifiedFiles
    • git status -s -uno lists all tracked modified files, in the previous use case it is a special case, that they are staged files
  • Feature: Log list modified files on failed rebase, if git fails with "unstaged changes"
  • Feature: Add actual branch names to log messages
  • Refactor: Rename variable masterBranchName to releaseBranchName and reference it as "release branch" in log messages
    • Because it is the branch from where the release is merged back, so the term "master" could be avoided

Screenshot:
image

Perhaps you can use some of these suggestions :)

Closes #30

greetings,
Basti

@saitho
Copy link
Owner

saitho commented Feb 15, 2022

I saw something was in the works but I totally missed this PR.
I'll take a look at it, thanks!

@saitho saitho self-assigned this Feb 15, 2022
@saitho saitho self-requested a review February 15, 2022 07:38
@saitho
Copy link
Owner

saitho commented Feb 18, 2022

@Blarkdackbyte There was an issue with the GitHub superlinter. I updated it in master.
Can you rebase your branch onto upstream's master? ;)

@Blarkdackbyte
Copy link
Contributor Author

@saitho
I rebased the branch :)
if there is anything else i can do, let me know

@saitho saitho merged commit e5a04d7 into saitho:master Feb 19, 2022
github-actions bot pushed a commit that referenced this pull request Feb 19, 2022
## [2.1.1](v2.1.0...v2.1.1) (2022-02-19)

### Bug Fixes

* improve logging ([#31](#31)) ([e5a04d7](e5a04d7))
@saitho
Copy link
Owner

saitho commented Feb 19, 2022

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Blarkdackbyte
Copy link
Contributor Author

Thank you very much!
It is an honor :)

@Blarkdackbyte Blarkdackbyte deleted the improve-logging branch February 19, 2022 13:46
@saitho
Copy link
Owner

saitho commented Feb 19, 2022

@Blarkdackbyte Thanks for using my plugin! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging
2 participants