-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Possibility to turn off feature, when image can be panned when cropped #98
Comments
I'm sorry, but I'm a bit confused. If the image is completely zoomed out, it shouldn't be possible to pan it any further, right? Would it be possible for you to share a video of your use case? |
You see how I have to scroll picture to the edge to change page? I would like the panning feature available only when the picture is zoomed in. Otherwise I would like to have standard cropped picture with trimmed edges. Screen.Recording.2024-08-27.at.08.57.30.mov |
Could you please share your composable code related to this UI? Maybe that could help us help you out better |
I cannot share any part of the code other than using your lib, but I don't see how my code would help with anything. It's not an error, but lack of possibility to turn off feature that you added to lib. Other person also mentioned it in his issue. |
bump |
Sorry for the delay, I’ve been dealing with chickenpox. 🤒 |
No worries, I hope you're okay 🤗 |
@saket Is something going to happen with this issue? |
I wasn't able to come up with a clean API that'd support this. Do you have suggestions? |
Well, your own suggestions sounded pretty good in this issue |
Will disabling over-zoom help you solve this?
|
How can I disable over-zoom to check if this helps? |
Disabling over-zoom isn't supported at the moment, but I'm also unable to imagine how that'll solve your panning issue mentioned here. After giving it some thought, I believe there could be a way to prevent panning here when the user zoom is zero. However this feels like a niche usecase, and it's hard to justify investing time in something that 99% people likely wouldn't need. That said, I'm willing to be proved. |
@saket I sent you a video, you can see clearly that user cannot swipe between pictures without stopping on every single one to scroll from edge to edge, just to change to next photo. Yo can't tell me that this behaviour is common, I truly believe that there should be a way to turn off this when picture is fully zoomed out. There was another issue on this matter, so I don't know why you're saying that 99% of people wouldn't need this feature. |
Hi, is it possible to add some kind of a flag allowing us to turn off following feature?
Use case is that I have a horizontal pager and I want to allow user to pan cropped picture when the picture is zoomed in, but not when it's completely zoomed out, because when he try to scroll to the next page, image is panned and getting to next picture is allowed only when we pan to the edge of the picture.
I would really appreciate if you added this feature. Thank you in advance.
The text was updated successfully, but these errors were encountered: