Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to mongodb ~3.x lib #112

Closed
etsuo opened this issue Dec 30, 2017 · 3 comments
Closed

Upgrade to mongodb ~3.x lib #112

etsuo opened this issue Dec 30, 2017 · 3 comments

Comments

@etsuo
Copy link
Member

etsuo commented Dec 30, 2017

We're currently on the 2.x series and 3.x has breaking changes, so it'll take a little bit of work.

@etsuo etsuo added this to the 0.8.0 milestone Dec 30, 2017
@etsuo etsuo self-assigned this Dec 30, 2017
@etsuo
Copy link
Member Author

etsuo commented Jan 3, 2018

v3 was just released, so still waiting on types:

Note that it looks like MongoClient.connect has changed it behavior:

This will break SakuraApi's implementation - see src/core/sakura-mongo-db-connection.ts:connect.

This will express itself as a break in getCollection @Model injected method.

@etsuo etsuo modified the milestones: 0.8.0, 0.9.0 Jan 9, 2018
@etsuo etsuo modified the milestones: 0.9.0, 0.10.0 Jan 30, 2018
@etsuo etsuo added this to the 0.12.0 milestone Apr 4, 2018
@etsuo etsuo removed their assignment Apr 6, 2018
@stevenschobert
Copy link
Contributor

👋 Here!

@etsuo
Copy link
Member Author

etsuo commented Apr 6, 2018

Thanks for the contribution @stevenschobert!

@etsuo etsuo closed this as completed Apr 6, 2018
@etsuo etsuo modified the milestones: 0.12.0, 0.13.0 Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants