Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar #4

Closed
vortechron opened this issue Sep 2, 2018 · 7 comments
Closed

sidebar #4

vortechron opened this issue Sep 2, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@vortechron
Copy link
Contributor

sidebar toggle should be cache. its very pain to re-toggle back when refreshing page or visit another section.

@saleem-hadad saleem-hadad added the enhancement New feature or request label Sep 2, 2018
@saleem-hadad
Copy link
Owner

Thank you @vortechron for your feedback.
I thought about it but I think the reason for making the sidebar hidden is to make the user focus more on the content without distractions. However, it's worth to mention we should cache the user preference if we assume the user navigate a lot. We will consider this feature in the upcoming version.

Thank you.

@saleem-hadad
Copy link
Owner

Hope the keyboard shortcut / helps you for now 😇.

@vortechron
Copy link
Contributor Author

@saleem-hadad your welcome 👍 , btw i really love the design and overall of this package.. im definitely going to use this package alot 💯 thank you

@saleem-hadad
Copy link
Owner

My pleasure 😍

@vortechron
Copy link
Contributor Author

@saleem-hadad yeah, im currently using / shortcut. but caching toggle is must have tho haha

@steveheinsch
Copy link

I do agree with the above. It was the first thing I noticed as well. It should remember your open/closed preference. This does look really nice, so good job!

@saleem-hadad
Copy link
Owner

saleem-hadad commented Sep 2, 2018

Thank you guys @vortechron @steveheinsch 💘

It's out there now: v1.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants