Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static ressources with new syntax only! #546

Closed
elvisbegovic opened this issue May 3, 2018 · 2 comments
Closed

static ressources with new syntax only! #546

elvisbegovic opened this issue May 3, 2018 · 2 comments

Comments

@elvisbegovic
Copy link

After opening
#486 and #467

Can we be smarter and propose static ressources (css files) on https://www.lightningdesignsystem.com vebsite in three versions:

  1. slds_new_syntax_only.css
  2. slds_old_syntax_only.css
  3. slds_new_and_old_syntax.css

Since 1 year we still have duplicated file size in our project because of breaking change in BEM syntax. And we only have this third point I mentioned.
(no scss)

Thanks

@elvisbegovic
Copy link
Author

Due to this I get this score with [Lighthouse] :
image

My file compressed could be 2x smaller with link to download static ressources without old BEM syntax

@engai
Copy link
Contributor

engai commented Jul 18, 2018

Hi @istiti, thank you for sharing your concerns and for the feature request.

Unfortunately, we do not plan on providing a variations of our static resource. The reason being that we primarily support the Salesforce platform and our teams need both the old and new BEM syntax. Moving forward, new components today are being built with the new syntax, but there are still use cases that utilize the old BEM that we must support. Both will remain in our static resource until the Salesforce platform no longer requires it.

We've provided you with regex in the past to remove the old syntax for your use case. Please feel free to use that in order to bring your file size down. Since the CSS classes are comma separated, I don't think that you will necessarily see a 2x decrease in file size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants