-
Notifications
You must be signed in to change notification settings - Fork 430
Updating package.module to transpiled ES6 modules (CRA compatibility issue) #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The other option is to remove |
After considering and reading many Github issue threads across a variety of projects, I am leaning toward a third copy of this library being included in the NPM module. Basis
Proposal
Aside: It’s annoying that TC39 is a zero-based index. I get why--it's a programming spec, but it’s confusing sometimes. FYI: There are five stages and number four is the finished stage. |
Adding to thread. @nutchanon-pho @tswardenski |
Create React App now supports ES6 modules (and the transpiling of
node_modules
folder) and is now usingpackage.modules
. I think this is what is causing #1269. I propose switchingpackage.modules
to be a transpiled version except for ES6 modules and not the source code.I'm hesitant to add a third version of this library within the node module, but
main
should be ES5/CJS andmodules
should be ES6, and I'd like to the source code present, especially for internal library users that are using.babelrc
and want to usemaster
branch pull downs in their app, etc.Another option is remove the CJS version and require ES6 module usage.
This will most likely be 0.9.x and include #1265 's
module.export
fixes.The text was updated successfully, but these errors were encountered: