Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engine] refactor the way we store internal fields to use a weak map #1299

Closed
ekashida opened this issue May 28, 2019 · 0 comments · Fixed by #1485
Closed

[engine] refactor the way we store internal fields to use a weak map #1299

ekashida opened this issue May 28, 2019 · 0 comments · Fixed by #1485

Comments

@ekashida
Copy link
Member

lwc/packages/@lwc/engine/src/framework/vm.ts

Line 616 in 37f8cf2

// TODO: this eventually should not rely on the symbol, and should use a Weak Ref

@ekashida ekashida changed the title [engine] refactor the way we store references to shadow root vm to use a weak map [engine] refactor the way we store internal fields to use a weak map May 28, 2019
@ekashida ekashida mentioned this issue Aug 27, 2019
Closed
@caridy caridy mentioned this issue Aug 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ekashida