Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ES2018 build target to ES2019+/ESNext #3366

Closed
nolanlawson opened this issue Feb 23, 2023 · 1 comment · Fixed by #3988
Closed

Bump ES2018 build target to ES2019+/ESNext #3366

nolanlawson opened this issue Feb 23, 2023 · 1 comment · Fixed by #3988
Labels
Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Collaborator

In our tsconfig.json files we have:

lwc/packages/@lwc/engine-core/tsconfig.json

Line 6 in f4d9638

"lib": ["dom", "es2018"]

This is because our build target is:

lwc/tsconfig.json

Line 12 in f4d9638

"target": "es2018",

... and we want to make sure we are compatible with ES2018 in our output.

However, we should really bump to something beyond ES2018 by now. This would be a breaking change, though.
@nolanlawson nolanlawson mentioned this issue Feb 23, 2023
Open
63 tasks
@nolanlawson nolanlawson added the Up for grabs Issues that are relatively small, self-contained, and ready for implementation label Oct 19, 2023
@nolanlawson
Copy link
Collaborator Author

I think we can technically do this now. We don't support anything but the latest browsers now.

@ekashida ekashida mentioned this issue Feb 8, 2024
Merged
@wjhsf wjhsf mentioned this issue Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update target to es2021 salesforce/lwc
1 participant
@nolanlawson