Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed best practices rules from base #636

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

jaig-0911
Copy link
Collaborator

removed best practices rules from base, added them to extended and updated readme accordingly.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1f988e) 96.32% compared to head (9c7f55d) 96.32%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          24       24           
  Lines         435      435           
  Branches       88       88           
=======================================
  Hits          419      419           
  Misses         16       16           
Files Coverage Δ
packages/preset-rules/src/base.ts 100.00% <ø> (ø)
packages/preset-rules/src/extended.ts 100.00% <ø> (ø)

@vaibhav-varshney vaibhav-varshney merged commit 73d09cc into master Jan 31, 2024
10 checks passed
@vaibhav-varshney vaibhav-varshney deleted the remove-best-practices branch January 31, 2024 07:06
Copy link

🎉 This PR is included in version 6.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants