Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include LICENSE.txt as a comment in dist #13

Open
nvmpaulmackintosh opened this issue Feb 8, 2022 · 3 comments
Open

Please include LICENSE.txt as a comment in dist #13

nvmpaulmackintosh opened this issue Feb 8, 2022 · 3 comments

Comments

@nvmpaulmackintosh
Copy link

The BSD 3-Clause license requires redistributions to reproduce elements of the license.

The license is currently included in a separate file https://github.com/salesforce/scv-connector-base/blob/master/LICENSE.txt
This makes it more difficult to include in our source code.

It would be easier to reproduce the license accordingly if it was included directly as a comment such as those supported by terser i.e.:

/*! ************************************
Copyright (c) ...
 **************************************/

This would then allow us to configure our bundler to preserve the license comments in our redistribution.

@estrudels
Copy link

estrudels commented Sep 22, 2022

I am curious if this is something the Salesforce team will apply, or is it a Won't Do?

@dlouvton @sfyz @vivektikoo-force

FYI @nvmpaulmackintosh

@estrudels
Copy link

@nvmpaulmackintosh I don't think this is gonna get any traction :(

@dlouvton @sfyz @vivektikoo-force

@estrudels
Copy link

@nvmpaulmackintosh Perhaps can close for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants