Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript declarations of Constants does not match with Javascript #50

Open
ashar-saleem opened this issue Feb 28, 2024 · 3 comments
Open

Comments

@ashar-saleem
Copy link

The typescript declaration of constants is not correct.
For example, in your Javascript, The QUEUED_CALL_STARTED in EVENT_TYPE is under a new section "VOICE"
EVENT_TYPE: {
VOICE: {
QUEUED_CALL_STARTED: 'QUEUED_CALL_STARTED',
}
}
Whereas in typescript it is
EVENT_TYPE: {
QUEUED_CALL_STARTED: 'QUEUED_CALL_STARTED',
}

It looks like the types.d.ts is not mapped correctly to the actual types.js file.
We can't upgrade the base connector and are unable to use the new features.

@ashar-saleem
Copy link
Author

@dlouvton

@paolo-botta-salesforce
Copy link
Contributor

@ashar-saleem I created enums in types.d.js. Can you use those instead?

@ashar-saleem
Copy link
Author

Hi Paolo,
I am already using them, but I really want to avoid mixing JS declarations with TS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants