Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property secure of undefined #144

Closed
thamerla opened this issue Jan 31, 2019 · 8 comments
Closed

Cannot read property secure of undefined #144

thamerla opened this issue Jan 31, 2019 · 8 comments
Assignees
Milestone

Comments

@thamerla
Copy link

Sample cookie I am trying to parse is included. Any tips on parsing?
Code:
https://repl.it/repls/ProfitableUnfortunateFossil

@stash stash self-assigned this Feb 4, 2019
@rnmhdn
Copy link

rnmhdn commented Sep 14, 2019

@awaterma august has ended. I also have this issue.

@awaterma
Copy link
Member

I've created a unit test for this now, working on finding time to resolve the issue.

@awaterma
Copy link
Member

Could you two try this with the master branch? I can't reproduce this:

master...awaterma:issue#144_property_secure

@rnmhdn
Copy link

rnmhdn commented Sep 22, 2019

I ended up changing my whole authentication system from session auth to JWT auth because I couldn't make cookies and csrf work:D

@awaterma awaterma added major We expect this work to be a major semver change and removed major We expect this work to be a major semver change labels Dec 9, 2019
@awaterma awaterma added this to the 4.x Release milestone Dec 9, 2019
@awaterma
Copy link
Member

awaterma commented Jan 2, 2020

This is not a bug. You can't call a method that takes a callback without a callback.

I wonder though, should we make this an API error? To clarify for users?

@medelibero-sfdc

@awaterma
Copy link
Member

awaterma commented Jan 2, 2020

@medelibero-sfdc -- let me know what you think, we can open another issue for error handling in async if we want to. I've got a unit test that proves this out -- that's the latest p/r.

@medelibero-sfdc
Copy link
Contributor

@awaterma I agree we should add in some extra error handling for this case so people get at least a more friendly exception. But I agree that this specific issue can be closed out and to create a new issue for the error handling bit.

@awaterma
Copy link
Member

awaterma commented Jan 3, 2020

Let's discuss in our next meeting. I think we should do the same as NodeJS when callers execute async methods incorrectly; which may very well be nothing. Let's investigate and create a story for how we want things to be, and then prioritize. :)

@awaterma awaterma closed this as completed Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants