Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress [object Object] defaults (probably Org flags) #651

Merged
merged 5 commits into from
May 30, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented May 30, 2024

@W-13215411@

#652 has the UT without the fix so you can prove the test is testing properly

@jshackell-sfdc
Copy link
Contributor

jshackell-sfdc commented May 30, 2024

QA:

  • ✅ set global target-org config var, generated files shouldn't contain "Default value: [object Object]"?
  • ✅ set local target-org config var, generated files shouldn't...
  • ✅ set global target-dev-hub config var, generated files shouldn't...
  • ✅ set local target-dev-hub config var, generated files shouldn't...
  • ❌ generate full set of command reference files with both config vars set to something, then compare output to currently checked in files, they should be the same.
    - The DITA files for "org delete scratch" and "org delete sandbox" now include a default value for --target-org (the value of my target-org config var). They didn't before. These are the only commands that do this -- other commands, such as "project deploy start", omit the default value of --target-org, which is correct for the CLI Reference.

Second QA:

  • ✅ set global target-org config var, generated files shouldn't contain "Default value: [object Object]"?
  • ✅ set local target-org config var, generated files shouldn't...
  • ✅ set global target-dev-hub config var, generated files shouldn't...
  • ✅ set local target-dev-hub config var, generated files shouldn't...
  • ✅ generate full set of command reference files with both config vars set to something, then compare output to currently checked in files, they should be the same.

@mshanemc mshanemc merged commit 5d70d2c into main May 30, 2024
10 checks passed
@mshanemc mshanemc deleted the sm/object-object-in-flag-defaults branch May 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants