Skip to content

Commit 9fe9619

Browse files
committed
fix: use 1.0.0 on plugins and libs
1 parent 44b8288 commit 9fe9619

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

src/commands/dev/generate/library.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ export default class GenerateLibrary extends SfCommand<void> {
8080
await generator.loadPjson();
8181

8282
generator.pjson.name = `${answers.scope}/${answers.name}`;
83+
generator.pjson.version = '1.0.0';
8384
generator.pjson.description = answers.description;
8485
generator.pjson.repository = `${answers.org}/${answers.name}`;
8586
generator.pjson.homepage = `https://github.com/${answers.org}/${answers.name}`;

src/commands/dev/generate/plugin.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,14 @@ export default class GeneratePlugin extends SfCommand<void> {
140140
name: `@salesforce/${answers.name}`,
141141
repository: `salesforcecli/${answers.name}`,
142142
homepage: `https://github.com/salesforcecli/${answers.name}`,
143-
description: answers.description,
144143
}
145144
: {
146145
name: answers.name,
147-
description: answers.description,
148146
};
149147

148+
updated.version = '1.0.0';
149+
updated.description = answers.description;
150+
150151
if (answers.author) {
151152
updated.author = answers.author;
152153
}

src/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export type NYC = {
2525

2626
export type PackageJson = {
2727
name: string;
28+
version: string;
2829
devDependencies: Record<string, string>;
2930
dependencies: Record<string, string>;
3031
files: string[];

test/commands/dev/generate/plugin.nut.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ describe('dev generate plugin NUTs', () => {
4040
const packageJson = readJson<PackageJson>(packageJsonPath);
4141

4242
expect(packageJson.name).to.equal('@salesforce/plugin-awesome');
43+
expect(packageJson.version).to.equal('1.0.0');
4344
expect(packageJson.author).to.equal('Salesforce');
4445
expect(packageJson.description).to.equal('a description');
4546
expect(packageJson.bugs).to.equal('https://github.com/forcedotcom/cli/issues');
@@ -85,6 +86,7 @@ describe('dev generate plugin NUTs', () => {
8586
const packageJson = readJson<PackageJson>(packageJsonPath);
8687

8788
expect(packageJson.name).to.equal('my-plugin');
89+
expect(packageJson.version).to.equal('1.0.0');
8890
expect(packageJson.author).to.equal('me');
8991
expect(packageJson.description).to.equal('a description');
9092

@@ -140,6 +142,7 @@ describe('dev generate plugin NUTs', () => {
140142
const packageJson = readJson<PackageJson>(packageJsonPath);
141143

142144
expect(packageJson.name).to.equal('my-plugin');
145+
expect(packageJson.version).to.equal('1.0.0');
143146
expect(packageJson.author).to.equal('me');
144147
expect(packageJson.description).to.equal('a description');
145148
const nycConfig = readJson<NYC>(path.join(session.dir, 'my-plugin', '.nycrc'));

0 commit comments

Comments
 (0)