feat: add network check and UT #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
May 21, 2024
src/diagnostics.ts
Outdated
| // salesforce endpoints | ||
| 'https://test.salesforce.com', | ||
| 'https://appexchange.salesforce.com/services/data', | ||
| // npm and yarn registries |
There was a problem hiding this comment.
Definitely agree on using jsforce conn.request for the first 2, since that's what we'd do in the code
I think the last 3 should mimic whatever we're doing in the real code.
ex: plugin-trust is callling npm cli to get the info (and that's going to be influenced by the npm proxy settings, maybe not exactly what jsforce is using). https://github.com/salesforcecli/plugin-trust/blob/8b583e13dac80995058e14eabf5eff1a1646376e/src/shared/npmCommand.ts#L63-L64
oclif/plugin-update uses got and doesn't do any proxy (maybe that's a whole other issue?) so you might replicate that setup?
mshanemc
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds a few network checks to verify the users machine can access
What issues does this PR fix or reference?
@W-15758164@