fix: allow some cmds to run outside a project #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
commented
Jul 19, 2024
| @@ -88,7 +87,7 @@ export class PackageListCommand extends SfCommand<PackageListCommandResult> { | |||
| NamespacePrefix, | |||
| ContainerOptions, | |||
| ConvertedFromPackageId, | |||
| Alias: this.project!.getAliasesFromPackageId(Id).join(), | |||
There was a problem hiding this comment.
so this alias info could be different depending on wether this runs inside an sfdx project or not.
cristiand391
commented
Jul 19, 2024
| @@ -25,7 +25,6 @@ export class Package1VersionCreateCommand extends SfCommand<PackageUploadRequest | |||
| public static readonly summary = messages.getMessage('summary'); | |||
| public static readonly description = messages.getMessage('description'); | |||
| public static readonly examples = messages.getMessages('examples'); | |||
| public static readonly requiresProject = true; | |||
There was a problem hiding this comment.
didn't see any usage of this.project in the command, probably a leftover from toolbelt migration
|
packag1 NUT failures are unrelated to these changes, you can see the same errors here: |
* refactor: pr comments as code * test: nut update for column order change, apiversion as number
|
QA: package list package installed list package1:version:create I don't know which 033 I should be using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow the following commands to be run outside an sfdx project:
package installed listpackage listpackage1 version createthe following ones still require an sfdx project:
mostly because the packaging lib expects an
SfProjectinstance to be able to resolve--packagebeing an alias defined in sfdx-project.json.internal doc: https://salesforce.quip.com/gnuNAtZkcOCP
we haven't decided on this work yet ⬆️
What issues does this PR fix or reference?
forcedotcom/cli#2932
@W-16189175@