Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop using npx for git commands #459

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix: stop using npx for git commands #459

merged 1 commit into from
Apr 13, 2022

Conversation

mdonnalley
Copy link
Contributor

What does this PR do?

Stop relying on npx for executing git commands

What issues does this PR fix or reference?

[skip-validate-pr]

@mdonnalley mdonnalley self-assigned this Apr 13, 2022
WillieRuemmele
WillieRuemmele approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Have we been able to verify this fixes the problem? Is git installed so it doesn't require npx to run?

@mdonnalley
Copy link
Contributor Author

These changes look good. Have we been able to verify this fixes the problem? Is git installed so it doesn't require npx to run?

@WillieRuemmele Yes, I was able to reproduce the problem locally on node 17 and verified that this fixes it. Circle includes git on their images so we should be good

@mdonnalley mdonnalley merged commit fe9973d into main Apr 13, 2022
@mdonnalley mdonnalley deleted the mdonnalley/npx-git branch April 13, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

@mshanemc mshanemc mshanemc approved these changes

Assignees

@mdonnalley mdonnalley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdonnalley @mshanemc @WillieRuemmele