Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intended release channel #694

Merged
merged 6 commits into from
Feb 27, 2023
Merged

Add intended release channel #694

merged 6 commits into from
Feb 27, 2023

Conversation

iowillhoit
Copy link
Contributor

What does this PR do?

Allows you to designate what channel this PR is intended for. This channel will get picked up by GHA to support: latest-rc, latest, nightly, and prereleases

What issues does this PR fix or reference?

@W-12599588@

@iowillhoit
Copy link
Contributor Author

iowillhoit commented Feb 24, 2023

EDIT: I went ahead and made this change. I think it is less confusing

One potential change... Right now it is required that the release channel is one of latest, latest-rc, or nightly. I did this because we want to require "dev releases" to be prereleases. I could change the validation logic a bit to say:

if ( release-channel is not one of [latest, latest-rc, nightly] && !prerelease) {
    throw Error("prerelease must be set to true if release-channel is not one of [...]")
}

This could potentially remove some confusion around the exactlyOne: ['release-channel', 'prerelease']. The release-channel is set on a single flag, but we enforce prerelease on non-standard channels

@mshanemc mshanemc merged commit ddcd1b1 into main Feb 27, 2023
@mshanemc mshanemc deleted the ew/release-channel branch February 27, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants