Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return-ref on functions doesn't compile #574

Open
nikomatsakis opened this issue Sep 18, 2024 · 2 comments
Open

return-ref on functions doesn't compile #574

nikomatsakis opened this issue Sep 18, 2024 · 2 comments
Milestone

Comments

@nikomatsakis
Copy link
Member

#[salsa::tracked(return_ref)]
fn test(db: &dyn salsa::Database) -> Vec<u32> {
    vec![]
}

doesn't compile (or something like it).

@nikomatsakis nikomatsakis added this to the Salsa 3.0 milestone Sep 18, 2024
@MichaReiser
Copy link
Contributor

Interesting. We use this very intensively but only with custom DBs.

@ShoyuVanilla
Copy link
Contributor

#[salsa::tracked(return_ref)]
fn test(db: &dyn salsa::Database) -> Vec<u32> {
    vec![]
}

doesn't compile (or something like it).

I haven't bisected yet but his function compiles well on latest master. Maybe it was somewhat other one like it or fixed somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants