Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker daemon configuration #9

Open
bbinet opened this issue Apr 5, 2017 · 3 comments
Open

docker daemon configuration #9

bbinet opened this issue Apr 5, 2017 · 3 comments

Comments

@bbinet
Copy link
Contributor

bbinet commented Apr 5, 2017

I would like to customize the docker daemon configuration through the /etc/docker/daemon.json file:
https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-configuration-file

Would it be possible to update the way /etc/docker/daemon.json is created in docker/host.sls so that it would be simple the json serialization of the docker.host.daemon pillar? Something like:

/etc/docker/daemon.json:
  file.managed:
    - contents: |
        {{ host.daemon | json(indent=2) | indent(8) }}
  - require:
    - pkg: docker_packages
  - watch_in:
    - service: docker_service
@fpytloun
Copy link
Member

fpytloun commented Apr 6, 2017

Hello,
it would be possible (by creating structure by other pillars and merging these options in) however we don't like this approach (having common metadata to generate any configuration) mostly because of philosophical and testing reasons. It's better to add features that are needed separately and introduce specific metadata for them (eg. like in case of setting up insecure registries).
Anyway in this case it's a lot of options to implement separately so maybe it's worth considering this way.

@bbinet
Copy link
Contributor Author

bbinet commented Apr 6, 2017

I can prepare a pull request if you want

@fpytloun
Copy link
Member

It would be great :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants