Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ng): add notification about upcoming ng promotion #36

Merged
merged 4 commits into from
Nov 27, 2019

Conversation

myii
Copy link
Member

@myii myii commented Nov 26, 2019

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Based on the deprecation done for the php-formula, as outlined here:

The first two PRs are merged together here.

Pillar / config required to test the proposed changes

N/A.

Debug log showing how the proposed changes work

Deprecation warning can be seen in Travis logs.

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@myii myii requested a review from daks November 26, 2019 11:42
Copy link
Member

@daks daks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks fine

@myii myii force-pushed the feat/warn-about-ng-promotion branch 2 times, most recently from 4b34d13 to b42491b Compare November 26, 2019 17:57
@myii myii force-pushed the feat/warn-about-ng-promotion branch 2 times, most recently from a2a7153 to 19ed30b Compare November 27, 2019 16:39
Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, one more 'ng' formula almost migrated

@myii myii force-pushed the feat/warn-about-ng-promotion branch from 19ed30b to 527cf1e Compare November 27, 2019 20:05
@myii myii merged commit cd1c23e into saltstack-formulas:master Nov 27, 2019
@myii
Copy link
Member Author

myii commented Nov 27, 2019

@daks @aboe76 Thanks for the reviews.

@myii myii deleted the feat/warn-about-ng-promotion branch November 27, 2019 20:20
@saltstack-formulas-travis

🎉 This PR is included in version 0.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants