Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Replace old nginx with nginx.ng (v1.0.0) #230

Closed
myii opened this issue Apr 26, 2019 · 6 comments · Fixed by #232
Closed

BREAKING CHANGE: Replace old nginx with nginx.ng (v1.0.0) #230

myii opened this issue Apr 26, 2019 · 6 comments · Fixed by #232
Labels
released

Comments

@myii
Copy link
Member

myii commented Apr 26, 2019 •
edited
Loading

The introduction of semantic-release in #229 paves the way for this formula to remove the old nginx configuration and to replace it with nginx.ng.
@myii myii assigned daks, noelmcloughlin and aboe76 and unassigned daks, noelmcloughlin and aboe76 Apr 26, 2019
@myii
Copy link
Member Author

myii commented Apr 26, 2019

@daks @noelmcloughlin @aboe76 Apologies, got mixed up with a PR and starting setting the assignees thinking it was reviewers! What I meant to do was simply ping each of you for the discussion.

@daks
Copy link
Member

daks commented Apr 26, 2019

I'm totally in favour of this change!

@noelmcloughlin
Copy link
Member

noelmcloughlin commented Apr 26, 2019 •
edited
Loading

I second that @daks
A non-breaking approach is to update the README to remove all references to ng, wipe all nginx SLS code and delete all jinja files in base directory. The base SLS file content is then updated to simply include nginx.ng.xxx from nginx.xxx - non breaking impact. I'm not advocating this but noting the approach.

@johnkeates
Copy link
Contributor

I am SO GLAD this is finally happening!

@daks daks mentioned this issue May 10, 2019
Merged
@myii myii closed this as completed in #232 May 12, 2019
@myii
Copy link
Member Author

myii commented May 12, 2019

@daks bit the bullet and delivered in #232! It's merged now so start modifying your configs!

@saltstack-formulas-travis
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Promote nginx:ng to nginx daks/nginx-formula
6 participants
@daks @aboe76 @johnkeates @myii @noelmcloughlin @saltstack-formulas-travis