Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have GitFS auto discover new envs for pillar_roots #10373

Closed
kenatbasis opened this issue Feb 12, 2014 · 4 comments
Closed

Have GitFS auto discover new envs for pillar_roots #10373

kenatbasis opened this issue Feb 12, 2014 · 4 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc. stale
Milestone

Comments

@kenatbasis
Copy link
Contributor

Just like how file_roots and gitfs work, I'd like to be able to point pillar_roots at a git repo, and have envs automatically created from new branches.

This is in the context of having many throwaway envs: gitfs + file_roots lets me create envs simply by branching, but I still have to manually modify the master config and restart it to add a pillar_roots env, which is problem with multiple dev teams.

@basepi
Copy link
Contributor

basepi commented Feb 13, 2014

Yes, this would be a cool feature to add, though we should probably hide it behind a config option to retain backwards compatibility. Pillar can have sensitive data so having a more well-defined set of environments to be made available is a useful feature that we want to retain.

@basepi basepi added the Feature label Feb 13, 2014
@basepi basepi added this to the Approved for future release milestone Feb 13, 2014
@kenatbasis
Copy link
Contributor Author

Implementing this now.

Essentially, abstracting fileserver away from just doing states, subclassing it for StatesFileserver and PillarFileserver, and abstracting each of the file server backends to not be state-specific.

It'll be mostly backwards compatible; I'll leave out the part of having old config variables map to the new ones.

@mbarrien
Copy link
Contributor

kenatbasis: Will your work possibly be useful for #9569 ?

@stale stale bot added the stale label Jun 20, 2017
@stale
Copy link

stale bot commented Jun 20, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot closed this as completed Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. stale
Projects
None yet
Development

No branches or pull requests

3 participants